Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Apr 27, 2022

Remove labs flag check when displaying beacon tiles, flag still controls creation of beacons


This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald requested a review from a team as a code owner April 27, 2022 09:29
@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 27, 2022
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #8423 (1405e79) into develop (12e8534) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 1405e79 differs from pull request most recent head 20b6882. Consider uploading reports for the commit 20b6882 to get more accurate results

@@             Coverage Diff             @@
##           develop    #8423      +/-   ##
===========================================
- Coverage    30.78%   30.74%   -0.04%     
===========================================
  Files          893      892       -1     
  Lines        50775    50700      -75     
  Branches     12923    12902      -21     
===========================================
- Hits         15629    15586      -43     
+ Misses       35146    35114      -32     
Impacted Files Coverage Δ
src/events/EventTileFactory.tsx 67.02% <100.00%> (+0.35%) ⬆️
src/utils/KeyVerificationStateObserver.ts 81.81% <0.00%> (-9.10%) ⬇️
src/hooks/useSettings.ts 81.25% <0.00%> (-6.25%) ⬇️
...ponents/views/beacon/LeftPanelLiveShareWarning.tsx 92.30% <0.00%> (-2.14%) ⬇️
src/components/views/rooms/ReadReceiptGroup.tsx 6.81% <0.00%> (-1.52%) ⬇️
src/components/structures/auth/Registration.tsx 30.17% <0.00%> (-0.90%) ⬇️
src/MatrixClientPeg.ts 30.33% <0.00%> (-0.78%) ⬇️
src/stores/OwnBeaconStore.ts 98.16% <0.00%> (-0.51%) ⬇️
src/components/views/rooms/EventTile.tsx 46.35% <0.00%> (-0.10%) ⬇️
src/utils/beacon/geolocation.ts 96.22% <0.00%> (-0.07%) ⬇️
... and 9 more

@kerryarchibald kerryarchibald enabled auto-merge (squash) April 29, 2022 14:05
@github-actions github-actions bot temporarily deployed to Netlify April 29, 2022 14:11 Destroyed
@kerryarchibald kerryarchibald merged commit 36fd9cb into develop Apr 29, 2022
@kerryarchibald kerryarchibald deleted the psf-962/beacon-timeline-filtering branch April 29, 2022 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants