This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Prevent invites from showing up in breadcrumbs #8344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
changed the title
germain-gg
suggested changes
Apr 19, 2022
Codecov Report
@@ Coverage Diff @@
## develop #8344 +/- ##
===========================================
- Coverage 30.47% 30.47% -0.01%
===========================================
Files 889 889
Lines 50547 50551 +4
Branches 12861 12864 +3
===========================================
Hits 15405 15405
- Misses 35142 35146 +4
|
turt2live
reviewed
Apr 26, 2022
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
this requires product review as it is currently a feature, not a bug
kittykat
approved these changes
Apr 29, 2022
Contributor
kittykat
left a comment
kittykat
left a comment
There was a problem hiding this comment.
Looks good from the product side 👍
germain-gg
suggested changes
May 3, 2022
src/stores/BreadcrumbsStore.ts
Outdated
Comment on lines
87
to
88
| const membership = room?room.getMyMembership():""; | ||
| if (room && membership==='join') await this.appendRoom(room); |
Contributor
There was a problem hiding this comment.
Suggested change
| const membership = room?room.getMyMembership():""; | |
| if (room && membership==='join') await this.appendRoom(room); | |
| const membership = room?.getMyMembership(); | |
| if (membership === "join") await this.appendRoom(room); |
Comment on lines
+90
to
+92
| } else if (payload.action === Action.JoinRoom) { | ||
| const room = this.matrixClient.getRoom(payload.roomId); | ||
| if (room) await this.appendRoom(room); |
Contributor
There was a problem hiding this comment.
Hm why do we need to add this?
Contributor
Author
There was a problem hiding this comment.
This line checks whether the user has successfully joined the room or not , then only we are adding that particular room to the breadcrumbs.
t3chguy
reviewed
May 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#21794
Signed-off-by: Ritik Kumar [email protected]
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.Preview: https://pr8344--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.