Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@nullity00
Copy link
Contributor

@nullity00 nullity00 commented Apr 15, 2022

Trimming whitespace at the beginning & end of the email as the user types.

Continuation of PR #8220
Fixes element-hq/element-web#20239

Signed-off-by: Reshma [email protected]


This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

Preview: https://pr8341--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@nullity00 nullity00 requested a review from a team as a code owner April 15, 2022 21:50
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #8341 (dc501a1) into develop (1afecc4) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #8341      +/-   ##
===========================================
- Coverage    30.02%   30.02%   -0.01%     
===========================================
  Files          879      879              
  Lines        50162    50164       +2     
  Branches     12769    12770       +1     
===========================================
  Hits         15062    15062              
- Misses       35100    35102       +2     
Impacted Files Coverage Δ
src/components/structures/auth/ForgotPassword.tsx 0.00% <0.00%> (ø)

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live turt2live merged commit 3750b90 into matrix-org:develop Apr 16, 2022
@nullity00
Copy link
Contributor Author

Thanks!

Thanks to you too !

Johennes pushed a commit to Johennes/matrix-react-sdk that referenced this pull request Apr 19, 2022
* Added an if to check if it is the email field

* Reverted the last change

* Added an if to check if its email field
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Email field on reset password is sensitive to spaces

2 participants