Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 14, 2022

This PR organizes style rules of _TimelineCard.scss structurally, in order to make it easier to debug style inconsistencies between the thread timeline and chat timeline on the right panel on element-hq/element-web#21774.

type: task


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr8315--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
@luixxiul luixxiul requested a review from a team as a code owner April 14, 2022 06:47
@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #8315 (dad0c49) into develop (aa33442) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #8315   +/-   ##
========================================
  Coverage    29.98%   29.98%           
========================================
  Files          879      879           
  Lines        50087    50087           
  Branches     12747    12747           
========================================
  Hits         15017    15017           
  Misses       35070    35070           

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live
Copy link
Member

though you now have conflicts.

@turt2live turt2live self-requested a review April 14, 2022 22:02
@turt2live turt2live enabled auto-merge (squash) April 14, 2022 22:03
@turt2live turt2live merged commit 8da6c98 into matrix-org:develop Apr 14, 2022
@luixxiul luixxiul deleted the NestTimelineCard branch April 14, 2022 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants