This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Live location sharing - extract live time UI for reuse #8283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2022 16:53
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
kerryarchibald
added
the
T-Task
Codecov Report
@@ Coverage Diff @@
## develop #8283 +/- ##
========================================
Coverage 29.51% 29.51%
========================================
Files 869 870 +1
Lines 49961 49961
Branches 12708 12708
========================================
Hits 14747 14747
Misses 35214 35214
|
turt2live
approved these changes
Apr 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
LiveTimeRemaininginto its own file, ready for reuse in beacon timeline tilesCurrent use in top bar, future use in Beacon timeline tile:
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr8283--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.