Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Mar 31, 2022

Fixes element-hq/element-web#21583


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

Preview: https://pr8202--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@germain-gg germain-gg requested a review from a team as a code owner March 31, 2022 11:29
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #8202 (81c01a0) into develop (4d14128) will increase coverage by 0.00%.
The diff coverage is 52.94%.

@@           Coverage Diff            @@
##           develop    #8202   +/-   ##
========================================
  Coverage    28.70%   28.71%           
========================================
  Files          852      852           
  Lines        49726    49738   +12     
  Branches     12618    12623    +5     
========================================
+ Hits         14276    14281    +5     
- Misses       35450    35457    +7     
Impacted Files Coverage Δ
src/Unread.ts 26.47% <28.57%> (-1.12%) ⬇️
src/stores/notifications/RoomNotificationState.ts 58.75% <57.14%> (-0.71%) ⬇️
...stores/notifications/RoomNotificationStateStore.ts 39.62% <100.00%> (+1.16%) ⬆️

@germain-gg germain-gg merged commit f4c25e0 into develop Mar 31, 2022
@germain-gg germain-gg deleted the gsouquet/thread-notification-21583 branch March 31, 2022 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Threads: Rooms set to mentions only don't bump in "unreadness" with replies to a thread

3 participants