Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Mar 28, 2022

Screenshot 2022-03-28 at 15 22 39


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr8177--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Kerry Archibald added 2 commits March 28, 2022 13:41
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
@kerryarchibald kerryarchibald requested a review from a team as a code owner March 28, 2022 11:42
@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 28, 2022
@kerryarchibald kerryarchibald enabled auto-merge (squash) March 28, 2022 11:42
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #8177 (cd075c5) into develop (e9b2aea) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #8177      +/-   ##
===========================================
- Coverage    28.55%   28.55%   -0.01%     
===========================================
  Files          851      851              
  Lines        49605    49608       +3     
  Branches     12573    12575       +2     
===========================================
  Hits         14167    14167              
- Misses       35438    35441       +3     
Impacted Files Coverage Δ
src/settings/Settings.tsx 75.00% <ø> (ø)
src/components/views/elements/PersistentApp.tsx 6.25% <0.00%> (-1.45%) ⬇️

@kerryarchibald kerryarchibald merged commit 69469e5 into develop Mar 29, 2022
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably add bylines to these at some point, but this works for now

@kerryarchibald kerryarchibald deleted the psf-798/live-location-copy branch March 29, 2022 06:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants