Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Mar 16, 2022

Fixes element-hq/element-web#21349

Will be displayed once, 1 minute after the user has loaded Element

Screen Shot 2022-03-16 at 11 27 20


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

Preview: https://pr8065--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@germain-gg germain-gg requested a review from janogarcia March 16, 2022 11:32
@germain-gg germain-gg requested a review from a team as a code owner March 16, 2022 11:32
"Unable to copy a link to the room to the clipboard.": "Unable to copy a link to the room to the clipboard.",
"Threads are no longer experimental! 🎉": "Threads are no longer experimental! 🎉",
"We’ve recently introduced key stability\n improvements for Threads, which also means\n phasing out support for experimental Threads.": "We’ve recently introduced key stability\n improvements for Threads, which also means\n phasing out support for experimental Threads.",
"All thread events created during the\n experimental period will now be rendered in\n the room timeline and displayed as replies.\n This is a one-off transition. Threads are now\n part of the Matrix specification.": "All thread events created during the\n experimental period will now be rendered in\n the room timeline and displayed as replies.\n This is a one-off transition. Threads are now\n part of the Matrix specification.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these \ns expected?

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #8065 (8a8ffe6) into develop (26e6f8d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 8a8ffe6 differs from pull request most recent head ae449d1. Consider uploading reports for the commit ae449d1 to get more accurate results

@@             Coverage Diff             @@
##           develop    #8065      +/-   ##
===========================================
- Coverage    27.02%   27.01%   -0.01%     
===========================================
  Files          866      866              
  Lines        52015    52021       +6     
  Branches     13185    13187       +2     
===========================================
  Hits         14055    14055              
- Misses       37960    37966       +6     
Impacted Files Coverage Δ
src/components/structures/MatrixChat.tsx 0.44% <0.00%> (-0.01%) ⬇️

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@germain-gg germain-gg enabled auto-merge (squash) March 16, 2022 16:23
@germain-gg germain-gg merged commit 59584cd into develop Mar 16, 2022
@germain-gg germain-gg deleted the gsouquet/threads-labs-21349 branch March 16, 2022 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inform labs threads users that their old threads have moved to the main timeline

5 participants