This repository was archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 814
Threads experimental transition modal #8065
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
reviewed
Mar 16, 2022
src/i18n/strings/en_EN.json
Outdated
| "Unable to copy a link to the room to the clipboard.": "Unable to copy a link to the room to the clipboard.", | ||
| "Threads are no longer experimental! 🎉": "Threads are no longer experimental! 🎉", | ||
| "We’ve recently introduced key stability\n improvements for Threads, which also means\n phasing out support for experimental Threads.": "We’ve recently introduced key stability\n improvements for Threads, which also means\n phasing out support for experimental Threads.", | ||
| "All thread events created during the\n experimental period will now be rendered in\n the room timeline and displayed as replies.\n This is a one-off transition. Threads are now\n part of the Matrix specification.": "All thread events created during the\n experimental period will now be rendered in\n the room timeline and displayed as replies.\n This is a one-off transition. Threads are now\n part of the Matrix specification.", |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these \ns expected?
Codecov Report
@@ Coverage Diff @@
## develop #8065 +/- ##
===========================================
- Coverage 27.02% 27.01% -0.01%
===========================================
Files 866 866
Lines 52015 52021 +6
Branches 13185 13187 +2
===========================================
Hits 14055 14055
- Misses 37960 37966 +6
|
janogarcia
approved these changes
Mar 16, 2022
andybalaam
approved these changes
Mar 16, 2022
Member
andybalaam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
luixxiul
reviewed
Mar 16, 2022
luixxiul
reviewed
Mar 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#21349
Will be displayed once, 1 minute after the user has loaded Element
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.Preview: https://pr8065--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.