This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Make tests more resilient for React 18 upgrade #12861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
t3chguy
added
the
T-Task
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
dbkr
reviewed
Aug 6, 2024
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
In general this is a lot of manual waitFors but it feels like these should be using the find queries that have the waiting built in?
test/components/views/dialogs/AccessSecretStorageDialog-test.tsx
Outdated
Show resolved
Hide resolved
| // simulate error initialising map in maplibregl | ||
| // @ts-ignore | ||
| mockMap.emit("error", { status: 404 }); | ||
| sleep(10).then(() => { |
Member
Author
There was a problem hiding this comment.
Timings change in React 18 and otherwise this error was emitted too early and missed by the component being rendered
Signed-off-by: Michael Telatynski <[email protected]>
dbkr
approved these changes
Aug 6, 2024
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
OK - there are lots more waitFors that look like they could be findBys, but I don't know the context
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #10314
Prepares for some timing changes in React 18 & some other changes in RTL update required for R18 support