This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix React contexts #12855
Merged
Fix React contexts #12855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
t3chguy
added
the
T-Task
Signed-off-by: Michael Telatynski <[email protected]>
dbkr
approved these changes
Aug 1, 2024
Member
Author
|
Bypassing sonar covg gate due to this just being type changes, and its very very close anyway |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #12852
Avoids
constructordefinition in sites usingcontextwhere it can be trivially avoided as it breaksReact.ComponentType<T>in React 17. Ensures all Class components usingstatic contextTypealso have acontexttype definition, ready for the switch over todeclaresyntax in ES2022.