Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Mar 29, 2023

This PR intends to replace commands to find buttons and menu items on timeline.spec.ts with ones of Cypress Testing Library merged with #10446, which are findButton and findMenuitem. It also replaces force clicks with realHover + findButton + click.

type: task

Signed-off-by: Suguru Hirahara [email protected]

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Mar 29, 2023
@luixxiul luixxiul mentioned this pull request Mar 29, 2023
3 tasks
- findButton
- findMenuitem

Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
@luixxiul luixxiul marked this pull request as ready for review March 30, 2023 07:21
@luixxiul luixxiul requested a review from a team as a code owner March 30, 2023 07:21
@kerryarchibald kerryarchibald enabled auto-merge (squash) April 3, 2023 23:08
@luixxiul
Copy link
Contributor Author

luixxiul commented Apr 4, 2023

Thanks for the review!

@germain-gg germain-gg removed their request for review April 4, 2023 07:11
@kerryarchibald kerryarchibald merged commit 4064ae7 into matrix-org:develop Apr 4, 2023
@luixxiul luixxiul deleted the test-timeline branch April 4, 2023 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants