This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add E2E test for FilePanel
#10400
Merged
Add E2E test for FilePanel
#10400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Z-Community-PR
- Add an empty one second OGG audio file Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
…panel Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Contributor
Author
|
@florianduros Would you please review when you have some time? Thanks in advance. |
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Contributor
Author
Contributor
Author
|
Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic E2E test for
FilePanel. It also add an empty one second OGG file to check the audio player on the panel. The main intention of this PR is to make sure thatEventTiles on the panel keep being rendered in the same way aftermx_EventTile:not([data-layout=bubble])is removed from_EventTile.pcss.Closes element-hq/element-web#24861
For #9033 (checking
EventTiles onFilePanel)type: task
Signed-off-by: Suguru Hirahara [email protected]
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.