Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Mar 7, 2023

Preparation for further work on permalinks / pills.

  • Pill now does only the view part
  • Adds usePermalink hook for the logic
  • Cover pill with tests

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 7, 2023
@weeman1337 weeman1337 force-pushed the weeman1337/refactor-pill branch from 654d3dd to b13348c Compare March 7, 2023 12:42
@weeman1337 weeman1337 added the X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue label Mar 7, 2023
@weeman1337 weeman1337 removed the X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue label Mar 7, 2023
@weeman1337 weeman1337 marked this pull request as ready for review March 7, 2023 14:49
@weeman1337 weeman1337 requested a review from a team as a code owner March 7, 2023 14:49
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

@weeman1337 weeman1337 merged commit ad26925 into develop Mar 8, 2023
@weeman1337 weeman1337 deleted the weeman1337/refactor-pill branch March 8, 2023 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants