Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Feb 1, 2023

Part of MSC3946

Supporting element-hq/element-web#24325


This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 1, 2023
@andybalaam andybalaam force-pushed the andybalaam/test-RoomListStore-predecessors branch from c841026 to 20e167b Compare February 1, 2023 14:34
@andybalaam andybalaam force-pushed the andybalaam/test-RoomListStore-predecessors branch from 20e167b to 72c2028 Compare February 1, 2023 14:41
@andybalaam
Copy link
Member Author

This change adds tests only, so qualifies for an exception to the coverage check.

@andybalaam
Copy link
Member Author

The strict warning is for code I moved but did not change so I would prefer not to mix fixing that with this refactoring.

@andybalaam andybalaam force-pushed the andybalaam/test-RoomListStore-predecessors branch from 669c31b to f31abc6 Compare February 1, 2023 17:20
@andybalaam andybalaam marked this pull request as ready for review February 1, 2023 17:20
@andybalaam andybalaam requested a review from a team as a code owner February 1, 2023 17:20
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me!

@andybalaam andybalaam merged commit b416e15 into matrix-org:develop Feb 2, 2023
@andybalaam andybalaam deleted the andybalaam/test-RoomListStore-predecessors branch February 2, 2023 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants