Support request in the browser and support supplying servers to try in joinRoom()
#764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has a bug when using browser-request where the query string for `server_name: [a, b]` comes out as `?server_name=a,b` instead of `?server_name=a&server_name=b`. This is due to browser-request not supporting the same qs options as request, so the qsStringifyOptions do nothing.
|
lgtm, other than paranoia about what weird regressions switching HTTP client is going to introduce. Particularly worried about whether timeout behaviour is going to change, or unexpected headers being introduced/removed by the lib etc. Timeouts particularly won't be caught by E2E tests or UTs. Might be worth checking for paranoia's sake? |
|
I walked around the app and didn't encounter any obvious issues. I also knocked out synapse to get a connection refused error and that worked. Also knocked out the entire VPS synapse runs on and the timeouts appear to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See matrix-org/matrix-react-sdk#2250