Allow msc4354_sticky_key to be optional on sticky events. #5073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Half-Shot wants to merge 1 commit into develop from hs/allow-empty-sticky-key

+2 −2

Contributor

Half-Shot commented Nov 10, 2025

As per the spec, these are not required. https://github.com/matrix-org/matrix-spec-proposals/blob/kegan/persist-edu/proposals/4354-sticky-events.md#implementing-an-ephemeral-map

Checklist

Tests written for new code (and old code if feasible).
New or updated public/exported symbols have accurate TSDoc documentation.
Linter and other CI checks pass.
Sign-off given on the changes (see CONTRIBUTING.md).


          Allow msc4354_sticky_key to be optional on sticky events.

e947845

Half-Shot requested a review from a team as a code owner

November 10, 2025 15:33

Half-Shot requested review from MidhunSureshR and t3chguy

November 10, 2025 15:33

BillCarsonFr approved these changes

View reviewed changes

Member

BillCarsonFr left a comment

✅

github-actions bot deployed to PR Documentation Preview

November 10, 2025 15:34

View deployment

Half-Shot added the T-Defect label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BillCarsonFr BillCarsonFr approved these changes

t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

At least 1 approving review is required to merge this pull request.

Labels