Add via parameter for MSC4156 #4247
Merged
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Marbach <[email protected]>
github-actions
bot
added
the
Z-Community-PR
t3chguy
reviewed
Jun 17, 2024
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
Can we not just be lazy
or always include both parameters
Contributor
Author
I thought I wouldn't pass review with that. 😅 But yes, if you're ok with this, it'll make things a bit less verbose. |
t3chguy
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the client-side implementation for matrix-org/matrix-spec-proposals#4156.
Checklist
public/exportedsymbols have accurate TSDoc documentation.