Export TimestampToEventResponse to use in matrix-react-sdk tests
#3223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
commented
Mar 21, 2023
src/client.ts
Outdated
| } | ||
|
|
||
| interface ITimestampToEventResponse { | ||
| export interface ITimestampToEventResponse { |
Contributor
Author
There was a problem hiding this comment.
5 tasks
weeman1337
reviewed
Mar 21, 2023
Contributor
weeman1337
left a comment
weeman1337
left a comment
There was a problem hiding this comment.
According to our new code style interfaces should not start with an I.
Can you rename it before merging this PR?
As suggested by @weeman1337, #3223 (review) See code style guide, https://github.com/vector-im/element-web/blob/50f8be4a623d2280a72920eb1679a4754961f807/code_style.md#typescript--javascript-typescript-javascript > Interface names should not be marked with an uppercase `I`.
Contributor
Author
Updated 👍 |
…ponse-to-use-in-tests
MadLittleMods
changed the title
ITimestampToEventResponse to use in matrix-react-sdk testsTimestampToEventResponse to use in matrix-react-sdk tests
weeman1337
approved these changes
Mar 21, 2023
Contributor
Author
|
Thanks for the review and approval @weeman1337 🐈 Is it possible to squash anymore and adjust the commit message? I've added it to the merge queue 🤷 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MadLittleMods
deleted the
madlittlemods/export-ITimestampToEventResponse-to-use-in-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export
TimestampToEventResponseto use inmatrix-react-sdktestsPart of matrix-org/matrix-react-sdk#10405
Checklist
Sign-off given on the changes (see CONTRIBUTING.md)This change is marked as an internal change (Task), so will not be included in the changelog.