Remove experimental support for MSC3903 v1 #3184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughns
force-pushed
the
hughns/msc3903-v2-remove-v1
branch
from
0ec1884 to
3d148ec
Compare
hughns
requested review from
richvdh and
weeman1337
and removed request for
a team
This is a deliberate breaking change on an unstable feature.
Deprecates several experimental types
This is a breaking change in code marked unstable/experimental Revert "Reinstate v1 support to make this a non-breaking change" This reverts commit 8977345.
hughns
force-pushed
the
hughns/msc3903-v2-remove-v1
branch
from
3d148ec to
db91c0c
Compare
andybalaam
approved these changes
Mar 2, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the items that were deprecated in #3155 and removes the code smells and duplication that were reported by SonarCloud.
The only known usage is in reac-sdk which should be merged first:
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.