Skip to content

Conversation

@dbkr
Copy link
Member

@dbkr dbkr commented Aug 31, 2022

Also move the are-we-in-the-call check up to the top so we don't log a bunch of stuff (and do a bunch of work) to then just exit the function because we haven't joined the call yet.

For element-hq/element-call#559

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@dbkr dbkr added the T-Task Tasks for the team like planning label Aug 31, 2022
@dbkr dbkr requested a review from a team as a code owner August 31, 2022 09:37
@dbkr dbkr merged commit db32420 into robertlong/group-call Aug 31, 2022
@dbkr dbkr deleted the dbkr/more_logging branch August 31, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants