Always block sending keys to unverified devices of verified users #2562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
approved these changes
Aug 4, 2022
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
Looks good - is there a bug somewhere tracking this change / documenting the decision for doing it?
Contributor
Author
|
Not that I'm aware of, this was more the output of internal Crypto Team conversations. Thanks for the review! |
duxovni
added a commit
that referenced
this pull request
Aug 8, 2022
…sers (#2562)" This will be rolled out again later with more accompanying UI adjustments, including clearer error messages and possibly the option to disable it per-room.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Sign-off given on the changes (see CONTRIBUTING.md)Here's what your changelog entry will look like:
✨ Features