Add local volume control #2525
Merged
Add local volume control #2525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <[email protected]>
Member
|
I'm trying to understand how this works - is |
Contributor
Author
Yes, it is in element-hq/element-call#468 |
Member
|
Oh, I see, volume has to be set on the media element in the front-end |
robintown
approved these changes
Jul 15, 2022
Contributor
Author
|
(going to block this until the element-call side is ready) |
Contributor
Author
|
Unblocking and merging as the element-call side got product approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-call#468
This change is marked as an internal change (Task), so will not be included in the changelog.