Add id to sdp_stream_metadata
#2493
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonBrandner
requested review from
kerryarchibald,
robintown and
weeman1337
and removed request for
kerryarchibald,
robintown and
weeman1337
SimonBrandner
commented
Jul 5, 2022
Contributor
Author
SimonBrandner
left a comment
SimonBrandner
left a comment
There was a problem hiding this comment.
Clearing review
SimonBrandner
requested review from
a team,
kerryarchibald,
robintown and
weeman1337
and removed request for
a team
weeman1337
reviewed
Jul 5, 2022
weeman1337
reviewed
Jul 5, 2022
Contributor
weeman1337
left a comment
weeman1337
left a comment
There was a problem hiding this comment.
Is it possible to add tests for the changes?
Contributor
Author
|
Marking as draft until #2495 is merged |
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
SimonBrandner/feat/sdp-meta-id
branch
from
434cb5f to
0ce0f7c
Compare
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
SimonBrandner/feat/sdp-meta-id
branch
from
0ce0f7c to
c85bf1b
Compare
Contributor
Author
|
Replaced by #2551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes matrix-org/matrix-spec-proposals#3077 (comment) and makes the implementation more future-proof
Here's what your changelog entry will look like:
✨ Features
idtosdp_stream_metadata(#2493).