MSC3786: Add a default push rule to ignore m.room.server_acl events
#2333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #2333 +/- ##
===========================================
+ Coverage 59.76% 59.78% +0.02%
===========================================
Files 91 91
Lines 16456 16456
Branches 3801 3801
===========================================
+ Hits 9835 9839 +4
+ Misses 6621 6617 -4
|
t3chguy
reviewed
Apr 30, 2022
Signed-off-by: Šimon Brandner <[email protected]>
|
I think the client has to more actively create the rule, otherwise client & server will be applying different push rules causing the notification_count being wrong |
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
changed the title
m.room.server_acl events
Signed-off-by: Šimon Brandner <[email protected]>
t3chguy
reviewed
May 3, 2022
Co-authored-by: Michael Telatynski <[email protected]>
|
Hmm @SimonBrandner this says |
That wasn't phrased well... It doesn't require it, it will just work better with it landed as we discussed, is it ok that I have merged the PR? |
|
Just double checking that you didn't jump the gun, merge timing is all up to you :) |
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
May 28, 2022
* Implement changes to MSC2285 (private read receipts) ([\matrix-org#2221](matrix-org#2221)). * Add support for HTML renderings of room topics ([\matrix-org#2272](matrix-org#2272)). * Add stopClient parameter to MatrixClient::logout ([\matrix-org#2367](matrix-org#2367)). * registration: add function to re-request email token ([\matrix-org#2357](matrix-org#2357)). * Remove hacky custom status feature ([\matrix-org#2350](matrix-org#2350)). * Remove default push rule override for MSC1930 ([\matrix-org#2376](matrix-org#2376)). Fixes element-hq/element-web#15439. * Tweak thread creation & event adding to fix bugs around relations ([\matrix-org#2369](matrix-org#2369)). Fixes element-hq/element-web#22162 and element-hq/element-web#22180. * Prune both clear & wire content on redaction ([\matrix-org#2346](matrix-org#2346)). Fixes element-hq/element-web#21929. * MSC3786: Add a default push rule to ignore `m.room.server_acl` events ([\matrix-org#2333](matrix-org#2333)). Fixes element-hq/element-web#20788.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#20788
Implements matrix-org/matrix-spec-proposals#3786
Synapse part to this: matrix-org/synapse#12601
Type: defect
Here's what your changelog entry will look like:
🐛 Bug Fixes
m.room.server_aclevents (#2333). Fixes ACL changes appear to be causing notifications in rooms element-hq/element-web#20788.