Change _unstable_getSharedRooms to _unstable_getMutualRooms
#2271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2271 +/- ##
===========================================
- Coverage 58.96% 58.95% -0.02%
===========================================
Files 91 91
Lines 16326 16329 +3
Branches 3766 3767 +1
===========================================
Hits 9627 9627
- Misses 6699 6702 +3
|
turt2live
requested changes
Apr 4, 2022
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
note also that this sort of rename is not required in order for the MSC to pass the implementation check. The name of the feature is less important than the function of it.
Contributor
Author
|
(Synapse (re)implementation will happen concurrently) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with changes to matrix-org/matrix-spec-proposals#2666, renaming from "shared" to "mutual".
This updates #1417
This blocks matrix-org/matrix-react-sdk#4897
Notes: Change
_unstable_getSharedRoomsto_unstable_getMutualRoomsand update unstable URL.Type: task
Signed-off-by: Jonathan de Jong <[email protected]>This change is marked as an internal change (Task), so will not be included in the changelog.