Skip to content

Conversation

@t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 1, 2022

Fixes element-hq/element-web#21633


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #2267 (f5595d2) into develop (d6f1c6c) will increase coverage by 0.35%.
The diff coverage is 90.62%.

@@             Coverage Diff             @@
##           develop    #2267      +/-   ##
===========================================
+ Coverage    58.96%   59.32%   +0.35%     
===========================================
  Files           91       91              
  Lines        16326    16349      +23     
  Branches      3766     3768       +2     
===========================================
+ Hits          9627     9699      +72     
+ Misses        6699     6650      -49     
Impacted Files Coverage Δ
src/models/event.ts 68.75% <ø> (+1.92%) ⬆️
src/event-mapper.ts 95.65% <66.66%> (-4.35%) ⬇️
src/client.ts 37.57% <85.71%> (-0.58%) ⬇️
src/models/room.ts 57.33% <90.14%> (+2.86%) ⬆️
src/models/event-timeline-set.ts 79.92% <100.00%> (+1.93%) ⬆️
src/models/relations.ts 50.66% <100.00%> (+13.33%) ⬆️
src/models/thread.ts 69.10% <100.00%> (+6.90%) ⬆️
src/sync.ts 65.37% <100.00%> (-0.22%) ⬇️
... and 3 more

@t3chguy t3chguy marked this pull request as ready for review April 1, 2022 14:23
@t3chguy t3chguy requested a review from a team as a code owner April 1, 2022 14:23
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at large! I'll give this a go and test it further

@germain-gg germain-gg merged commit dde4285 into develop Apr 7, 2022
@germain-gg germain-gg deleted the t3chguy/fix/21633 branch April 7, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edited thread replies are rendering the original, unedited content

4 participants