Fix thread & main timeline partitioning logic #2264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c with other methods
Codecov Report
@@ Coverage Diff @@
## develop #2264 +/- ##
===========================================
- Coverage 58.96% 58.96% -0.01%
===========================================
Files 91 91
Lines 16346 16325 -21
Branches 3774 3768 -6
===========================================
- Hits 9639 9626 -13
+ Misses 6707 6699 -8
|
Contributor
|
Does this possibly fix element-hq/element-web#21613 ? |
Member
Author
|
Unlikely, that looks like thread initialisation/pagination somehow getting the wrong events from relations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#21599
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.