-
-
Notifications
You must be signed in to change notification settings - Fork 650
Voice rooms prototype #2249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice rooms prototype #2249
Conversation
Signed-off-by: Robin Townsend <[email protected]>
SimonBrandner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you!
Codecov Report
@@ Coverage Diff @@
## develop #2249 +/- ##
===========================================
- Coverage 58.11% 58.10% -0.01%
===========================================
Files 92 92
Lines 16427 16429 +2
Branches 3782 3782
===========================================
Hits 9546 9546
- Misses 6881 6883 +2
|
turt2live
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks fine on this side - thanks!
Signed-off-by: Robin Townsend <[email protected]>
turt2live
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this side lgtm
See matrix-org/matrix-react-sdk#8084 for the full details.
Notes: Support call room type from MSC3417
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.