Skip to content

Conversation

@robintown
Copy link
Member

@robintown robintown commented Mar 18, 2022

See matrix-org/matrix-react-sdk#8084 for the full details.

Notes: Support call room type from MSC3417


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

@robintown robintown requested a review from a team as a code owner March 18, 2022 18:32
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #2249 (2a445c0) into develop (75674d9) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 2a445c0 differs from pull request most recent head b2f274d. Consider uploading reports for the commit b2f274d to get more accurate results

@@             Coverage Diff             @@
##           develop    #2249      +/-   ##
===========================================
- Coverage    58.11%   58.10%   -0.01%     
===========================================
  Files           92       92              
  Lines        16427    16429       +2     
  Branches      3782     3782              
===========================================
  Hits          9546     9546              
- Misses        6881     6883       +2     
Impacted Files Coverage Δ
src/@types/event.ts 100.00% <ø> (ø)
src/models/room.ts 55.48% <0.00%> (-0.12%) ⬇️

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks fine on this side - thanks!

@robintown robintown requested a review from turt2live March 18, 2022 22:06
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this side lgtm

@turt2live turt2live merged commit 65316ff into matrix-org:develop Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants