Skip to content

Convert IndexedDB store & worker to Typescript #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 14, 2021
Merged

Convert IndexedDB store & worker to Typescript #1779

merged 4 commits into from
Jul 14, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 12, 2021 •
edited
Loading

Requires element-hq/element-web#17962

Avoids using event.target on IndexedDB events due to microsoft/TypeScript#28293

@t3chguy t3chguy requested a review from a team July 12, 2021 17:42
jryans
jryans approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, thanks! 😄

Base automatically changed from t3chguy/ts/c1 to develop July 14, 2021 16:19
@t3chguy t3chguy merged commit 3df1c4b into develop Jul 14, 2021
@t3chguy t3chguy deleted the t3chguy/ts/c2 branch July 14, 2021 16:44
@dbkr dbkr added the T-Task Tasks for the team like planning label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t3chguy @jryans @dbkr