Do not honor string power levels #1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Raimist <[email protected]>
jryans
requested changes
Jun 23, 2021
Collaborator
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Thanks, seems reasonable overall, but would be good to use the same checks in all power level paths.
Synapse enforces this but I guess it doesn't hurt to also check here Signed-off-by: Aaron Raimist <[email protected]>
Contributor
Author
|
I'm not sure where else you want changed. As far as I can tell this is the only place Element uses the JS SDK to show a PL. These string power levels aren't going to last a much longer anyway since I also made a PR to enforce integers in Synapse matrix-org/synapse#10232 so I don't think it's worth putting a whole lot more time in on the client side. |
jryans
approved these changes
Jun 30, 2021
Collaborator
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
That's all I had in mind, thanks. Just seems good to have similar checks all around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-react-sdk#6245