Remove broken surrogate handling for UTF-16 #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Matrix specification says everything should be UTF-8: > For the default HTTP transport, all API calls use a Content-Type of application/json. In addition, all strings MUST be encoded as UTF-8. ... and our handling of UTF-16 surrogates was quite broken here, which sometimes resulted in broken JSON after `CompactJSON`.
neilalexander
added a commit
to matrix-org/dendrite
that referenced
this pull request
May 26, 2022
neilalexander
added a commit
that referenced
this pull request
Aug 30, 2022
This somewhat reverts #314 and refactors things so that the broken JSON that could happen before with faulty surrogates will no longer happen.
neilalexander
added a commit
that referenced
this pull request
Aug 30, 2022
This somewhat reverts #314 and refactors things so that the broken JSON that could happen before with faulty surrogates will no longer happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Matrix specification says everything should be UTF-8:
... and our handling of UTF-16 surrogates was quite broken here, which sometimes resulted in broken JSON after
CompactJSON.