Fix bugs in checkUserLevels
#306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
added a commit
to matrix-org/dendrite
that referenced
this pull request
May 6, 2022
kegsay
added a commit
to matrix-org/complement
that referenced
this pull request
May 6, 2022
kegsay
added a commit
to matrix-org/complement
that referenced
this pull request
May 6, 2022
* Add regression test when modifying events_default xref matrix-org/gomatrixserverlib#306 * Update tests/csapi/power_levels_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
checkUserLevelsfunction was considering the default user level if the user didn't have a key defined, which meant that promoting or demoting a user above/below the default power levels could result in the event auth failing, even though the changes should be allowed.It could also end up adding duplicates, which just seems wasteful.