Skip to content

MNT: fix circle #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2021
Merged

MNT: fix circle #84

merged 3 commits into from
Nov 15, 2021

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Nov 11, 2021

No description provided.

@jimustafa
Copy link
Contributor

I think the errors with circle are related to the python version being different from what was used when pinning the requirements. Given that the cheatsheets are more an "application" than a "library", the python version should probably be fixed. The requirements were originally generated with python 3.7.3, and it looks like python 3.9 was used in #83.

Can circle do something similar to gh actions (below), and specify the python version?

- uses: actions/setup-python@v2
with:
python-version: 3.7

@jklymak
Copy link
Member Author

jklymak commented Nov 12, 2021

I mean, I'm sure its probably possible. I wasn't planning to prioritize this, so maybe I'll move to draft. @jimustafa if you wanted to take over trying to get this to work, I'd be great with that. Otherwise, I'll try to circle back to it after 3.5.0 is released.

@jklymak jklymak marked this pull request as draft November 12, 2021 08:28
@jklymak
Copy link
Member Author

jklymak commented Nov 12, 2021

(to be clear, my experience with CircleCI is copying other setups and googling - I'm not particularly knowledgeable!)

@jimustafa
Copy link
Contributor

I can take a look at circle and try to get a config working. In the meantime, should we remove the circle config introduced in #83 to prevent the failed checks?

@jklymak
Copy link
Member Author

jklymak commented Nov 13, 2021

I think so? It was just to bootstrap being able to turn circle on at the project level for this repo.

@jklymak
Copy link
Member Author

jklymak commented Nov 13, 2021

I just made the circle test a placeholder from now. Not sure what happens if we remove it altogether and then merge, if we need to reenable at the project level

@jklymak jklymak marked this pull request as ready for review November 13, 2021 07:47
@jklymak
Copy link
Member Author

jklymak commented Nov 15, 2021

I'll self merge this to unbreak the build. Note this is not user-facing...

@jklymak jklymak merged commit 297ef35 into matplotlib:master Nov 15, 2021
@jklymak jklymak deleted the mnt-fix-circle branch November 15, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants