Fix non-existent cartopy projection #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
QuLogic
reviewed
Mar 7, 2023
- the correct name of the projection is Orthographic instead of Cartographic. - use standard import convention to make the line a bit shorter, see https://scitools.org.uk/cartopy/docs/latest/matplotlib/intro.html. - fix wrong API link for cartopy - add missing (lost) API link for 3d
The https scheme is needed as check-links.py checks for 200. Pdfx prepends http:// to links without a scheme which results in a permanent redired (308) to 'https://gitter.im/matplotlib/matplotlib' and hence causes check-links.py to fail.
QuLogic
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://scitools.org.uk/cartopy/docs/latest/matplotlib/intro.html.
Also removed some commented lines from previous changes, as I think the history should be better looked up in version control than in the code itself.