Skip to content

Move Equation.to() method to its base class #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dario-coscia merged 1 commit into from
Nov 4, 2025
Merged

Move Equation.to() method to its base class #694

dario-coscia merged 1 commit into from
Nov 4, 2025
+36 −31

Conversation

@GiovanniCanali
Copy link
Collaborator

@GiovanniCanali GiovanniCanali commented Oct 29, 2025

Description

This PR fixes #688

Checklist

  • Code follows the project’s Code Style Guidelines
  • Tests have been added or updated
  • Documentation has been updated if necessary
  • Pull request is linked to an open issue

@GiovanniCanali GiovanniCanali self-assigned this Oct 29, 2025
@GiovanniCanali GiovanniCanali added pr-to-fix Label for PR that needs modification maintenance labels Oct 29, 2025
@GiovanniCanali GiovanniCanali changed the title Move .to() method to the base class Move Equation.to() method to its base class Oct 29, 2025
@GiovanniCanali GiovanniCanali marked this pull request as ready for review October 29, 2025 16:31
@GiovanniCanali GiovanniCanali requested a review from a team as a code owner October 29, 2025 16:31
@GiovanniCanali GiovanniCanali added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Oct 29, 2025
@GiovanniCanali GiovanniCanali removed the request for review from a team October 29, 2025 16:31
dario-coscia
dario-coscia requested changes Oct 29, 2025
View reviewed changes
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add self.to(...) also in SystemEquation residual function

@GiovanniCanali
Copy link
Collaborator Author

GiovanniCanali commented Nov 3, 2025

You need to add self.to(...) also in SystemEquation residual function

Fixed, thank you for spotting this!

@dario-coscia dario-coscia merged commit d4fa3ea into mathLab:dev Nov 4, 2025
34 of 37 checks passed
@GiovanniCanali GiovanniCanali deleted the fix_equation branch November 26, 2025 13:10
GiovanniCanali added a commit to GiovanniCanali/PINA that referenced this pull request Dec 2, 2025
@GiovanniCanali
move to method to the interface (mathLab#694)
93eaa7b
GiovanniCanali added a commit to GiovanniCanali/PINA that referenced this pull request Dec 2, 2025
@GiovanniCanali
move to method to the interface (mathLab#694)
50e5723
GiovanniCanali added a commit to GiovanniCanali/PINA that referenced this pull request Dec 2, 2025
@GiovanniCanali
move to method to the interface (mathLab#694)
b5dc223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dario-coscia dario-coscia dario-coscia approved these changes

Assignees

@GiovanniCanali GiovanniCanali

Labels

maintenance pr-to-review Label for PR that are ready to been reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GiovanniCanali @dario-coscia