Skip to content

Add SINDy model #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

Add SINDy model #660

merged 1 commit into from
Oct 8, 2025

Conversation

lorenzotomada
Copy link

Description

This PR fixes #659.

Checklist

  • Code follows the project’s Code Style Guidelines
  • Tests have been added or updated
  • Documentation has been updated if necessary
  • Pull request is linked to an open issue

@lorenzotomada lorenzotomada requested review from a team and dario-coscia as code owners October 6, 2025 20:00
@FilippoOlivo FilippoOlivo changed the base branch from master to dev October 6, 2025 20:14
@GiovanniCanali GiovanniCanali force-pushed the SINDy_branch branch 2 times, most recently from 86d481e to 191b024 Compare October 7, 2025 08:05
GiovanniCanali
GiovanniCanali approved these changes Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@GiovanniCanali GiovanniCanali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lorenzotomada, thanks for your PR! The code looks clean and well-structured.

@GiovanniCanali GiovanniCanali added enhancement New feature or request pr-to-fix Label for PR that needs modification labels Oct 7, 2025
@GiovanniCanali
Copy link
Collaborator

GiovanniCanali commented Oct 7, 2025 •
edited
Loading

Let's add a tutorial before merging!

@lorenzotomada
Copy link
Author

lorenzotomada commented Oct 7, 2025 •
edited
Loading

Thanks for the code review, your feedback was really helpful!
I'm working on the tutorial and will follow up shortly 👍🏻

dario-coscia
dario-coscia requested changes Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I had a look and everything looks pretty solid, only few minimal changes. Let me know when the tutorial is ready for review. Great job!

@lorenzotomada @GiovanniCanali
Add SINDy model
fde5975 
Co-authored-by: GiovanniCanali <[email protected]>
@dario-coscia
Copy link
Collaborator

I would merge it as it is, and make a tutorial in another PR @lorenzotomada. Thanks for the effort!

@dario-coscia dario-coscia merged commit 5966d03 into mathLab:dev Oct 8, 2025
18 of 19 checks passed
@lorenzotomada
Copy link
Author

Great, thanks for the support @GiovanniCanali and @dario-coscia !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dario-coscia dario-coscia dario-coscia requested changes

@GiovanniCanali GiovanniCanali GiovanniCanali approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request pr-to-fix Label for PR that needs modification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add SINDY model

3 participants

@lorenzotomada @GiovanniCanali @dario-coscia