minor generalizations, additions, fixes #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affeldt-aist
added
enhancement ✨
zstone1
approved these changes
Jul 12, 2023
Contributor
zstone1
left a comment
zstone1
left a comment
There was a problem hiding this comment.
I'm happy with these generalizations and renamings. Just a heads up it will generate minor merge conflicts with my PRs, but I'll fix on my end once this is in.
This was referenced Jul 17, 2023
affeldt-aist
added a commit
to affeldt-aist/analysis
that referenced
this pull request
Jul 20, 2023
proux01
pushed a commit
that referenced
this pull request
Jul 21, 2023
proux01
removed
the
TODO: MC2 port
IshiguroYoshihiro
pushed a commit
to IshiguroYoshihiro/analysis
that referenced
this pull request
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integralM#938This PR deals with a few trivialities to ease forthcoming reviews.
Motivation for this change
Things done/to do
CHANGELOG_UNRELEASED.mdCompatibility with MathComp 2.0
TODO: HB portto make sure someone ports this PR tothe
hierarchy-builderbranch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.