Skip to content

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Jun 1, 2023

Motivation for this change

These fixes and lemmas are used in a proof of Hoelder's inequality to be PRed soon.

@hoheinzollern

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist added enhancement ✨ This issue/PR is about adding new features enhancing the library TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. labels Jun 1, 2023
@affeldt-aist affeldt-aist added this to the 0.6.3 milestone Jun 1, 2023
@affeldt-aist affeldt-aist mentioned this pull request Jun 3, 2023
3 tasks
@affeldt-aist affeldt-aist modified the milestones: 0.6.3, 0.6.4 Jun 20, 2023
Copy link
Contributor

@zstone1 zstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one confusing lemma statement. If adding a x!=0 condition breaks too many things, at least making the coercion explicit will make it more readable for me.

theories/exp.v Outdated
Qed.

Lemma power_posr0 a : a `^ 0 = 1.
Lemma power_pos0 x : 0 `^ x = (x == 0)%:R.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything about this statement is uncomfortable. The fact that we have a theorem that explicitly relies on 0 ^ 0 behavior is awkward. And this uses the most surprising coercion, nat_of_bool. I see that this lemma gets used a bunch. But would x != 0 -> 0^x = 0 work in its place?

Copy link
Member Author

@affeldt-aist affeldt-aist Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it looks a bit too ssreflectish. Changing to the format you propose reduces the size of scripts a bit (see the last commit) so if moreover the statement is more readable this is a good change.

@affeldt-aist affeldt-aist force-pushed the exp_20230601 branch 2 times, most recently from 8df3452 to 9b1885c Compare June 28, 2023 05:05
@affeldt-aist affeldt-aist merged commit da20131 into math-comp:master Jun 29, 2023
affeldt-aist added a commit to affeldt-aist/analysis that referenced this pull request Jul 12, 2023
* powere_pos lemmas

Co-authored-by: Alessandro Bruni <[email protected]>
proux01 pushed a commit that referenced this pull request Jul 17, 2023
* powere_pos lemmas

Co-authored-by: Alessandro Bruni <[email protected]>
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Jul 17, 2023
IshiguroYoshihiro pushed a commit to IshiguroYoshihiro/analysis that referenced this pull request Sep 7, 2023
* powere_pos lemmas

Co-authored-by: Alessandro Bruni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants