adding second countable stuff #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zstone1
added
enhancement ✨
2 tasks
Member
|
I committed to fix a compilation error and I linted a bit but it deserves more attention. |
CohenCyril
approved these changes
May 2, 2023
affeldt-aist
added a commit
that referenced
this pull request
May 4, 2023
* adding second countable stuff * fix, lint * merging --------- Co-authored-by: Reynald Affeldt <[email protected]>
proux01
removed
the
TODO: MC2 port
IshiguroYoshihiro
pushed a commit
to IshiguroYoshihiro/analysis
that referenced
this pull request
Sep 7, 2023
* adding second countable stuff * fix, lint * merging --------- Co-authored-by: Reynald Affeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The last of the general theory required for #834. This adds definitions for basis, second_countable, and two lemmas that I need. It's nowhere near complete in terms of the theory of different kind of basis. But it gets the job done.
Things done/to do
CHANGELOG_UNRELEASED.mdCompatibility with MathComp 2.0
TODO: HB portto make sure someone ports this PR tothe
hierarchy-builderbranch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.