Cantor misc #893
Merged
Cantor misc #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zstone1
added
enhancement ✨
affeldt-aist
approved these changes
Apr 12, 2023
Member
affeldt-aist
left a comment
affeldt-aist
left a comment
There was a problem hiding this comment.
This looks ok to me. I added a commit with minor fixes and shortening proposals that you are free to revert. Shouldn't discrete_ent and discrete_ball appear in the documentation of the file?
2 tasks
proux01
pushed a commit
to proux01/analysis
that referenced
this pull request
Apr 29, 2023
* missing topology facts * changelog * cauchy compact * nitpicking * updating docs --------- Co-authored-by: Reynald Affeldt <[email protected]>
proux01
pushed a commit
to proux01/analysis
that referenced
this pull request
Apr 29, 2023
* missing topology facts * changelog * cauchy compact * nitpicking * updating docs --------- Co-authored-by: Reynald Affeldt <[email protected]>
proux01
added a commit
that referenced
this pull request
Apr 29, 2023
* missing topology facts * changelog * cauchy compact * nitpicking * updating docs --------- Co-authored-by: zstone1 <[email protected]> Co-authored-by: Reynald Affeldt <[email protected]>
proux01
removed
the
TODO: MC2 port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A few more stray facts I need for working with cantor spaces.
Things done/to do
CHANGELOG_UNRELEASED.md(only append to minimize problems when merging/rebasing)
(you can consider the use of
etc/changes.shto generate the changelog)Compatibility with MathComp 2.0
TODO: HB portto make sure someone ports this PR tothe
hierarchy-builderbranch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.