fix and strengthen eq_bigmax and eq_bigmin #863
Merged
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affeldt-aist
approved these changes
Mar 1, 2023
Member
affeldt-aist
left a comment
affeldt-aist
left a comment
There was a problem hiding this comment.
Just need to be rebased.
t6s
force-pushed
the
strengthen_eq_bigmax
branch
from
8f88221 to
632fbad
Compare
Member
Author
|
squashed and rebased |
Member
|
are these theorems not already backported in mathcomp? |
Member
Author
|
Member
|
so there should be a PR there too |
Member
Author
|
affeldt-aist
force-pushed
the
strengthen_eq_bigmax
branch
from
632fbad to
5390875
Compare
affeldt-aist
added
the
"bug" 🐛
hoheinzollern
pushed a commit
to hoheinzollern/analysis
that referenced
this pull request
Mar 24, 2023
hoheinzollern
added a commit
to hoheinzollern/analysis
that referenced
this pull request
Apr 1, 2023
work on Hoelder's inequality expeS, fin_numX (math-comp#829) \bar R canonicals for tblattice Co-authored-by: Quentin Vermande <[email protected]> Co-authored-by: Alessandro Bruni <[email protected]> Co-authored-by: Takafumi Saikawa <[email protected]> Co-authored-by: Reynald Affeldt <[email protected]> add lemma power12_sqrt fix and strengthen eq_bigmax and eq_bigmin (math-comp#863) Itv (math-comp#869) * Add itv.v Taking inspiration on signed.v, replacing sign by intervals. * Add interval multiplication * Add hints to automatically solve _ <= 1 goals * Test to see if usable as a replacement for prob * use notation from mathcomp_extra.v * changelog and rm redundant code * prefix duplicated identifiers --------- Co-authored-by: Reynald Affeldt <[email protected]> complete changelog fubini for s-finite measures (math-comp#877) fixes, cleaning powere_pos lemmas fixed `powere_pos` definition more lemmas for `powere_pos` progress in fixing hoelder wip powere_pos lemmas cleanup up wip wip
hoheinzollern
added a commit
to hoheinzollern/analysis
that referenced
this pull request
Apr 13, 2023
work on Hoelder's inequality expeS, fin_numX (math-comp#829) \bar R canonicals for tblattice Co-authored-by: Quentin Vermande <[email protected]> Co-authored-by: Alessandro Bruni <[email protected]> Co-authored-by: Takafumi Saikawa <[email protected]> Co-authored-by: Reynald Affeldt <[email protected]> add lemma power12_sqrt fix and strengthen eq_bigmax and eq_bigmin (math-comp#863) Itv (math-comp#869) * Add itv.v Taking inspiration on signed.v, replacing sign by intervals. * Add interval multiplication * Add hints to automatically solve _ <= 1 goals * Test to see if usable as a replacement for prob * use notation from mathcomp_extra.v * changelog and rm redundant code * prefix duplicated identifiers --------- Co-authored-by: Reynald Affeldt <[email protected]> complete changelog fubini for s-finite measures (math-comp#877) fixes, cleaning powere_pos lemmas fixed `powere_pos` definition more lemmas for `powere_pos` progress in fixing hoelder wip powere_pos lemmas cleanup up wip wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Lemmas
eq_bigmaxandeq_bigmininmathcomp_extra.vis wrongly stated in weaker formsthat does not respect their argument P in the returned type.
Things done/to do
This PR fixes the problem by strengthening the statements and amending the proofs.
CHANGELOG_UNRELEASED.md(do not edit former entries, only append new ones, be careful:
merge and rebase have a tendency to mess up
CHANGELOG_UNRELEASED.md)Automatic note to reviewers
Read this Checklist and put a milestone if possible.