-
Notifications
You must be signed in to change notification settings - Fork 64
Hahn decomposition theorem #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5505d2f to
afebf42
Compare
11bdaa1 to
2cfbef6
Compare
2cfbef6 to
5c20d7a
Compare
28db4cd to
3f94ae7
Compare
ce4191c to
a71c16a
Compare
7ccf660 to
cbba235
Compare
|
@IshiguroYoshihiro could you also take a look? |
ping |
|
ping @IshiguroYoshihiro @t6s |
zstone1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look pretty good, actually. I haven't gone through the proofs in too much detail. But they look, more-or-less, aligned with the textbook proofs. While I'm sure there are probably improvements in there, I'm not too worried about it. Qed is Qed.
What interests me is the use of FinNumFun. It actually causes some headache later, with mine_cvg_0_cvg_0. That proof is pretty easy in R because _ * 2 and min (_,1) are both trivially continuous. It's annoying to have to reprove all this in \bar R. I would love to see
- Somehow support this kind of sorta-heterogeneous types in the definition of this hierarchy.
- Transport the goal from
\bar RtoR. This seems much more plausible. We could do it ad-hoc, by showingfineis a homeomorphism on the image of(fun n => mine (x n * (2^-1)%:E) 1). But it should be possible to do this more generically.
This is not a dealbreaker for merging the PR. I'm mostly just recording this discomfort. This is something always brushed under the rug in textbooks, so no surprise we gotta deal with it here.
|
Indeed, it is pretty frustrating to have this proof ( |
|
In the last commit b674879 I split the lemma |
493a1fa to
5140460
Compare
- introduces signed measures/charges Co-authored-by: IshiguroYoshihiro
- introduces signed measures/charges Co-authored-by: IshiguroYoshihiro
Co-authored-by: IshiguroYoshihiro
based on PR #836(has been merged into master)Motivation for this change
Things done/to do
CHANGELOG_UNRELEASED.mdAutomatic note to reviewers
Read this Checklist and put a milestone if possible.