Skip to content

Conversation

@proux01
Copy link
Collaborator

@proux01 proux01 commented Aug 18, 2025

Addressing this discussion: #1649 (comment)
Cc @affeldt-aist

Motivation for this change
Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@proux01 proux01 force-pushed the ereal-constants branch 3 times, most recently from a330fae to 932a1de Compare August 19, 2025 07:41
@proux01
Copy link
Collaborator Author

proux01 commented Aug 19, 2025

CI green, this seems to work

@affeldt-aist
Copy link
Member

I just added information to the changelog (this arguably looks like internal machinery but this is about side-effects and numbers, difficult issues that are likely to resurface) and a short comment to motivate the addition (but you probably have better insights to share).

@proux01
Copy link
Collaborator Author

proux01 commented Sep 13, 2025

Thanks, I added the header doc (not sure why it's duplicated though) and squashed. If CI is happy, I guess this can be merged.

@affeldt-aist affeldt-aist self-requested a review September 15, 2025 02:48
@affeldt-aist affeldt-aist merged commit fcefe89 into math-comp:master Sep 15, 2025
66 of 67 checks passed
@proux01 proux01 deleted the ereal-constants branch September 15, 2025 06:12
hoheinzollern pushed a commit to hoheinzollern/analysis that referenced this pull request Sep 22, 2025
yosakaon pushed a commit to yosakaon/analysis that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants