Skip to content

Conversation

@affeldt-aist
Copy link
Member

Motivation for this change
  • this PR also moves from unstable.v to mathcomp_extra.v lemmas that have been merged into mathcomp or finmap
Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.13.0 milestone Jul 7, 2025
@affeldt-aist affeldt-aist requested review from hoheinzollern and t6s July 7, 2025 03:55
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Jul 7, 2025
@affeldt-aist affeldt-aist changed the title extract a last few lemmas from the the sampling branch extract a last few lemmas from the sampling branch Jul 7, 2025
Copy link
Member

@hoheinzollern hoheinzollern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides @t6s 's comments, it looks OK.

- this PR also moves from unstable.v to mathcomp_extra.v
  lemmas that have been merged into mathcomp or finmap

Co-authored-by: Takafumi Saikawa <[email protected]>
@affeldt-aist affeldt-aist merged commit 9fa1465 into math-comp:master Jul 7, 2025
34 checks passed
yosakaon pushed a commit to yosakaon/analysis that referenced this pull request Dec 4, 2025
- this PR also moves from unstable.v to mathcomp_extra.v
  lemmas that have been merged into mathcomp or finmap

Co-authored-by: Takafumi Saikawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants