Skip to content

Conversation

@affeldt-aist
Copy link
Member

Motivation for this change

one generalization taken out of the sampling branch

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

Co-authored-by: Alessandro Bruni <[email protected]>
Co-authored-by: Cyril Cohen <[email protected]>
Co-authored-by: Pierre Roux <[email protected]>
Co-authored-by: Takafumi Saikawa <[email protected]>
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Jun 24, 2025
@affeldt-aist affeldt-aist added this to the 1.12.0 milestone Jun 24, 2025
@affeldt-aist
Copy link
Member Author

since the CI is green and that it is a strict generalization, we can maybe quickly merge this one?

@t6s
Copy link
Member

t6s commented Jun 24, 2025

other parts look good

@affeldt-aist
Copy link
Member Author

other parts look good

Let's merge then. Thank you!

@affeldt-aist affeldt-aist merged commit 1ab6825 into math-comp:master Jun 24, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants