-
Notifications
You must be signed in to change notification settings - Fork 64
Conv convention #1630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conv convention #1630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This will unlock the port of convex spaces from InfoTheo. Regarding the PR in itself, the technical lemmas about the parameters of the quasi-associativity should be better named and documented. However, I think that it will be more efficient for us to do that along the port of more properties of convex spaces. So I am ok to merge with the proviso that we agree to carefully review that part of the library again in the near future.
d5b5db0 to
63f0b6c
Compare
63f0b6c to
3e58146
Compare
|
I am afraid of naming the submodule |
|
Let's be more precise and even hide the module name behind a definition in lowercase akin to |
* change the convention for the convex combination operation --------- Co-authored-by: Reynald Affeldt <[email protected]>
* change the convention for the convex combination operation --------- Co-authored-by: Reynald Affeldt <[email protected]>
Motivation for this change
This PR changes the convention of the convex combination operation in
convex.vfroma <| t |> b = (1-t)a + tbtota + (1-t)b, to make this compatible with infotheo (https://gihtub.com/affeldt-aist/infotheo).There has been a discussion about these two options, and the former
has been chosen for its compatibility with the homotopical notion of paths,
while the latter is algebraically natural.
After a discussion in a analysis-dev meeting, a conclusion was made to change it to the latter.
Also, there is now a
line_pathinset_interval.vwhich essentially implements the former conventionand has an appropriately geometric name.
Therefore I think it is now reasonable to do this PR.
@CohenCyril @affeldt-aist
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers