Skip to content

lemma extracted from the sampling branch to help rebasing #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
affeldt-aist merged 1 commit into from
Apr 28, 2025
Merged

lemma extracted from the sampling branch to help rebasing #1592

affeldt-aist merged 1 commit into from
Apr 28, 2025

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Apr 28, 2025

Motivation for this change
Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Apr 28, 2025
@affeldt-aist affeldt-aist added this to the 1.11.0 milestone Apr 28, 2025
@affeldt-aist affeldt-aist marked this pull request as ready for review April 28, 2025 06:46
hoheinzollern
hoheinzollern approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@hoheinzollern hoheinzollern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@affeldt-aist affeldt-aist merged commit 22fff84 into math-comp:master Apr 28, 2025
32 of 35 checks passed
IshiguroYoshihiro pushed a commit to IshiguroYoshihiro/analysis that referenced this pull request Jun 20, 2025
@affeldt-aist @IshiguroYoshihiro
lemma extracted from the sampling branch to help rebasing (math-comp#…
4c50e90 
…1592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hoheinzollern hoheinzollern hoheinzollern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@affeldt-aist @hoheinzollern