Generalize gt0_cvgMly/Ny #1565
Merged
Generalize gt0_cvgMly/Ny #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshiguroYoshihiro
force-pushed
the
generalize_gt0_cvgMly/Ny_20250411
branch
from
931dfe9 to
7011176
Compare
zstone1
approved these changes
Apr 14, 2025
Contributor
zstone1
left a comment
zstone1
left a comment
There was a problem hiding this comment.
Strict generalizations make for easy reviews. Looks good to me
affeldt-aist
force-pushed
the
generalize_gt0_cvgMly/Ny_20250411
branch
from
b4fb212 to
f00ffef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
generalized
gt0_cvgMlyandgt0_cvgMlNyfrom@[x --> +oo]/@[x --> -oo]to@[x --> F]for any filter F.Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers