fixes #1131 #1132
Merged
fixes #1131 #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ping @CohenCyril ? |
affeldt-aist
force-pushed
the
topology_20240105
branch
from
0ddc369 to
34c7bcf
Compare
Member
Author
|
Since we gain a few lines I will probably merge this one for the next release. |
CohenCyril
requested changes
Jan 17, 2024
Member
CohenCyril
left a comment
CohenCyril
left a comment
There was a problem hiding this comment.
Yes, except for the changelog which contains too much wrt this PR
Member
Author
|
The failing CI check seems to be an installation problem of finmap, I guess the needed version is not available yet. |
affeldt-aist
added a commit
to affeldt-aist/analysis
that referenced
this pull request
Jan 19, 2024
proux01
added
TODO: MC2 port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done/to do
CHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersCompatibility with MathComp 2.0
TODO: HB portto make sure someone ports this PR tothe
hierarchy-builderbranch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.