fixes #1123 (unusable lemma) #1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Takafumi Saikawa <[email protected]> Co-authored-by: Zachary Stone <[email protected]>
affeldt-aist
added
the
"bug" 🐛
zstone1
approved these changes
Dec 22, 2023
affeldt-aist
added a commit
to affeldt-aist/analysis
that referenced
this pull request
Dec 28, 2023
* fixes math-comp#1123 Co-authored-by: Takafumi Saikawa <[email protected]> Co-authored-by: Zachary Stone <[email protected]>
proux01
pushed a commit
that referenced
this pull request
Dec 28, 2023
* fixes #1123 Co-authored-by: Takafumi Saikawa <[email protected]> Co-authored-by: Zachary Stone <[email protected]>
proux01
added
TODO: MC2 port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixes #1123
@t6s
@zstone1 I noticed after the fact that you also fix this lemma in you PR on total variation so that I put you as co-author of this commit
Things done/to do
- [ ] added corresponding entries inCHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersCompatibility with MathComp 2.0
TODO: HB portto make sure someone ports this PR tothe
hierarchy-builderbranch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.